#5441: Add unit tests for django.contrib.formtools
------------------------+---------------------------------------------------
Reporter: adrian | Owner: simeon
Status: assigned | Component: django.contrib.formtools
Version: SVN | Resolution:
Keywords: | Stage: Accepted
Has_patch: 1 | Needs_docs: 0
Needs_tests: 0 | Needs_better_patch: 1
------------------------+---------------------------------------------------
Comment (by simeon):
Ok, I updated the patch (run from trunk directory). Latest version is
5441.2.diff. Class name is now "PreviewTests" - tests for other (future)
parts of formtools could be added with a different class name. Methods of
PreviewTests are now underscored instead of CamelCased and running pep8.py
on the tests.py file results in no errors (did I really terminate a line
with a semicolon? Sorry - my day job still involves lots of PHP.) If there
are any other style issues I need to be aware of, please let me know.
I'm also opening a bug on the documentation to suggest that the
"Contributing" section mention pep8.py. Maybe this is common knowledge to
experienced devs but it helped me catch some issues I wouldn't have seen
(trailing whitespace, semi-colons)...
--
Ticket URL: <http://code.djangoproject.com/ticket/5441#comment:13>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
