#30776: AuthenticationForm's username field doesn't set maxlength HTML 
attribute.
------------------------------+----------------------------------------
     Reporter:  felixxm       |                    Owner:  Sam Reynolds
         Type:  Bug           |                   Status:  assigned
    Component:  contrib.auth  |                  Version:  master
     Severity:  Normal        |               Resolution:
     Keywords:                |             Triage Stage:  Accepted
    Has patch:  1             |      Needs documentation:  0
  Needs tests:  0             |  Patch needs improvement:  0
Easy pickings:  0             |                    UI/UX:  0
------------------------------+----------------------------------------

Comment (by gopackgo90):

 Is it a good idea to change a bunch of the field properties in the form's
 init? Wouldn't it make more sense to set these as part of the
 UsernameField's init like
 
[https://github.com/gopackgo90/django/commit/dd9be672ec079e90b8dfa4a8e91f31ec8185438f]?
 In Django 2.0, the username field also had a MaxLengthValidator when it
 was created, which wouldn't exist if the proposed PR is accepted.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30776#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.86c3fa6dbc9b123c7b4b7a6590dfc7ee%40djangoproject.com.

Reply via email to