#30439: Translations issues on Django upgrade due to unexpected changes in plural forms --------------------------------------+------------------------------------ Reporter: Michal Čihař | Owner: Rodrigo Type: Bug | Status: assigned Component: Internationalization | Version: 2.2 Severity: Normal | Resolution: Keywords: | Triage Stage: Accepted Has patch: 1 | Needs documentation: 1 Needs tests: 0 | Patch needs improvement: 1 Easy pickings: 0 | UI/UX: 0 --------------------------------------+------------------------------------
Comment (by Rodrigo): Replying to [comment:37 Carlton Gibson]: Hey Carlton, thanks for taking a look > I've given this an initial look but without a clearer consensus that it's the right approach I'm not sure what to say. > I'll look again but I would like to see positive agreement on the discussion thread (which is already too long...) > before committing to the approach. > That's the main issue. I understand, one of the subjacent problems of the issue is the relation with Transifex. The proposed fix solves this independently - from Transifex or any translation provider - by having the plural forms consistency "inside" or "by" Django. > Then, just on the PR, the docs changes don't explain what's going on clearly. The new settings and makemessages options don't have a ''Why'' you'd use them anywhere. > (That discussion is here and in the mailing list, but it needs to be clear for someone installing the new version.) No doubt they can be improved, I tried to be as concise as possible in the docs. Despite of adding some lines of "off-line code", they are quite simple: - Changes on the plural forms may lead to breakage of your translated front-end, so a warning is added and a measure is taken to encourage your action - If you see this warning, use makemessages --comply-plural-forms to update and align user catalogs with the main plural form so you ensure your translations consistency - If above is not sufficient for you, use LOCALE_ROOT and makemessages --collect-base-catalogs to take translation files into your project, customize them to your wish and maintain them in your release cycle. This is what the [https://github.com/django/django/pull/12280/files?file- filters%5B%5D=.py&file-filters%5B%5D=.txt&file-filters%5B%5D=No+extension &file-filters%5B%5D=dotfile#diff-71461bf83587a4ca9617ddc8761a5908R282 "main doc"] tries to communicate. > Once those are in place, release notes. Indeed, they weren't included > Finally the PR needs a bit of a tidy, and they'll no doubt be nitpicks but I want to sort out the more fundamental issues before we spend energy there. I tried to write the code in line with the makemessages command style mostly, and although I extensively test it, no code is bug-free and not perfectible -- Ticket URL: <https://code.djangoproject.com/ticket/30439#comment:38> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/063.f40d31dfe859cb67fe65d5f16d12fc41%40djangoproject.com.