#31472: UserAdmin returns incorrect fieldsets when model has overridden
__bool__.
-------------------------------------+-------------------------------------
Reporter: krnr | Owner: krnr
Type: | Status: closed
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution: wontfix
Keywords: UserAdmin, | Triage Stage:
add_fieldsets, get_fieldsets | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by krnr):
I was fine with the existing admin class (because I seldom meet such user
models), but recently I saw this PR:
https://github.com/django/django/commit/5cd4c3e5595128bc1a3f28f2e30bab2e4dd3b1b7
and I was thinking "why does it have nice check against None in one method
and doesn't have in another?"
and it's not about checking against all possible `if instance` (yeah, it
doesn't worth it), just about fieldsets.
but that's OK. just leave it be if anyone else will be curious.
--
Ticket URL: <https://code.djangoproject.com/ticket/31472#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/062.7cfbf74351132bc03ed565fff36907bc%40djangoproject.com.
