#31520: ManifestStaticFilesStorage should not raise ValueError on missing file
when
manifest_strict=False
-------------------------------+------------------------------------
Reporter: thenewguy | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by Carlton Gibson):
* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
* stage: Unreviewed => Accepted
Comment:
Hi @thenewguy.
I'll accept this provisionally, since it looks correct on read through —
though I didn't yet run the test cases.
Can you add your new tests to the PR (perhaps just as a first commit so
it's easy to see those failing.)
The suggested patch causes the existing tests to fail
`staticfiles_tests.test_storage.TestCollectionManifestStorage.test_missing_entry`,
so can you adjust that too?
Uncheck the flags when it's ready and I'll take a look.
Thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/31520#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.80271bc479e825687f5afebbbe44a1da%40djangoproject.com.
