#31180: Deprecate default_app_config.
-------------------------------------+-------------------------------------
Reporter: Aymeric Augustin | Owner: Aymeric
| Augustin
Type: New feature | Status: assigned
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* needs_better_patch: 0 => 1
* stage: Ready for checkin => Accepted
Comment:
This isn't quite ready.
There's a test failure from the new check, for a test added in
dd1ca50b096bf0351819aabc862e91a9797ddaca (after the PR here was first
created):
{{{
======================================================================
ERROR: test_translation_loading (i18n.tests.TranslationLoadingTests)
"loading_app" does not have translations for all languages provided by
----------------------------------------------------------------------
Traceback (most recent call last):
...
File "django/django/apps/registry.py", line 354, in set_installed_apps
self.populate(installed)
File "django/django/apps/registry.py", line 91, in populate
app_config = AppConfig.create(entry)
File "django/django/apps/config.py", line 235, in create
app_name, app_config_class.__module__, app_config_class.__name__,
django.core.exceptions.ImproperlyConfigured: Cannot import 'loading_app'.
Check that 'i18n.loading_app.apps.LoadingAppConfig.name' is correct.
}}}
I suspect that's just an artifact of the test case.
Plus, there are a couple of new review comments to double-check.
--
Ticket URL: <https://code.djangoproject.com/ticket/31180#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.448a568565b86818e49d5af669752f69%40djangoproject.com.
