#5767: EmailField should render as a mailto anchor in admin list page
------------------------------+---------------------------------------------
   Reporter:  hax             |                Owner:  nobody                
     Status:  new             |            Component:  Admin interface       
    Version:  newforms-admin  |           Resolution:                        
   Keywords:  EmailField      |                Stage:  Design decision needed
  Has_patch:  1               |           Needs_docs:  0                     
Needs_tests:  0               |   Needs_better_patch:  1                     
------------------------------+---------------------------------------------
Comment (by SmileyChris):

 Oh, silly me - how did I overlook that? For penance, I'll properly review
 the patch :)

 1. I don't see any benefit of falling back to `EMPTY_CHANGELIST_VALUE` for
 a text field

 2. Since your `if` only checks for `is not None`, an empty string would
 return `'<a href="mailto:";></a>'`

-- 
Ticket URL: <http://code.djangoproject.com/ticket/5767#comment:3>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to