#2879: [patch] Add live test server support to test framework
--------------------------------------------------------+-------------------
Reporter: Mikeal Rogers <[EMAIL PROTECTED]> | Owner:
nobody
Status: reopened | Component:
Unit test system
Version: | Resolution:
Keywords: | Stage:
Accepted
Has_patch: 1 | Needs_docs:
1
Needs_tests: 1 | Needs_better_patch:
1
--------------------------------------------------------+-------------------
Changes (by russellm):
* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
* needs_docs: 0 => 1
Comment:
Replying to [comment:19 Mikeal Rogers <[EMAIL PROTECTED]>]:
> The patch attached to this bug won't work in the current trunk.
>
> I can write another one but after seeing what happened to the last patch
I'd like to know that someone is actually going to review it before it
becomes outdated like the last one.
The requirements for this patch are the same as every other patch, as
documented here:
http://www.djangoproject.com/documentation/contributing/#patch-style
In short:
1. Your patch needs to encompass a single idea. In this case, adding a
TestCase with a test server. The :memory: change is probably a reasonable
change, but is unrelated to the ticket purpose. It should be logged and
processed as separate issue.
2. Your patch needs tests. A regression test that demonstrates that the
new test case works is an absolute minimum. Unless a patch is trivial, or
I need the feature/fix myself, or it's difficult/impossible to test the
feature (e.g., testing command line options to ./manage.py), I won't even
bother looking at a patch until it has tests. I'm too busy to spend my
days trying to work out how other peoples code should work. A test is how
you prove you are serious about using my time.
3. Your patch needs documentation. If you have tests, documentation can
wait until after an initial review - but if you don't have a test, then
you're going to need to document how your feature works.
4. (Generally required, but not so much in this case since this ticket is
on my watch list) - the triage team needs to review and promote the patch.
--
Ticket URL: <http://code.djangoproject.com/ticket/2879#comment:21>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
