#32013: Field choice attribute returns different objects in forms.
---------------------------+--------------------------------------
Reporter: Jaap Roes | Owner: nobody
Type: Bug | Status: closed
Component: Forms | Version: 3.1
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------+--------------------------------------
Comment (by Jaap Roes):
Replying to [comment:8 Carlton Gibson]:
> Hi Jaap. In normal cases I would expect manually setting choices to work
just fine, since we proxy `__str__` &co to the underlying object. The
filtering cases are interesting but a `.value` would resolve the more
esoteric ones.
I did some further manual testing and checking and can confirm everything
else seems to work fine. Is Django itself not depending on the first item
of the choices tuple being a `ModelChoiceIteratorValue` instance?
Since in some cases the entire choices attribute is set to a list of
`[(pk, str), ...]` I can imagine at some point code internal to Django
breaking as the first item doesn't have a `.value` or `.instance`
attribute. It doesn't seem to break *yet*, but it might? Should I go and
wrap things in a `ModelChoiceIteratorValue` just to be sure?
--
Ticket URL: <https://code.djangoproject.com/ticket/32013#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/063.5bfec7cfe6d92436a733b3074b606a4a%40djangoproject.com.
