#5104: CheckboxInput should return False if not found
---------------------------+------------------------------------------------
Reporter: SmileyChris | Owner: nobody
Status: new | Component: django.newforms
Version: SVN | Resolution:
Keywords: | Stage: Ready for checkin
Has_patch: 1 | Needs_docs: 0
Needs_tests: 0 | Needs_better_patch: 0
---------------------------+------------------------------------------------
Comment (by mtredinnick):
Okay, I like the approach Chris is taking here and I'm going to commit a
small variation on this patch (predominantly, including some more
documentation clarifications). I'm not going to remove the "validates
nothing" lines in the third patch, since explicitly including them makes
it clear we haven't just forgotten to list the validation conditions.
I agree that this will make the natural behaviour clearer for people and I
think this should put the issue to rest.
I'm not going to change the current default for !BooleanField subclasses
to make it required=False because it's not possible to make that sort of
change and break existing code, so people writing {{{BooleanField()}}} at
the moment will have their validation conditions weakened and might not
notice it (we try to make all backwards incompatible changes fatal if you
don't notice them). It simply isn't that hard to type {{{required=False}}}
to make that risk necessary. A little annoying for some people; hardly
fatal, though.
--
Ticket URL: <http://code.djangoproject.com/ticket/5104#comment:9>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
