#32139: Add check, that raise TemplateException, when argument 'only' provided
more
then once in tag 'include'
-------------------------------------+-------------------------------------
Reporter: Mikhail Fesenko | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Template system | Version: master
Severity: Normal | Resolution:
| worksforme
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):
* status: new => closed
* resolution: => worksforme
Comment:
Hi Mikhail, thanks for this contribution, but the test you submitted
passes without your patch. Further, I don't see how your patch would
execute since `if option in options` raises an exception a few lines
above. Finally, and for the same reason, I don't think the test you
provided meaningfully increases coverage since there are test methods
`test_variable_twice()` and `test_syntax_error_duplicate_option()` that
already test this.
--
Ticket URL: <https://code.djangoproject.com/ticket/32139#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.88c09809e8c286db1248a82e7c0ec80c%40djangoproject.com.
