#32165: Add pre-commit Hooks
-------------------------------+--------------------------------------
     Reporter:  David Smith    |                    Owner:  nobody
         Type:  Uncategorized  |                   Status:  closed
    Component:  Uncategorized  |                  Version:  master
     Severity:  Normal         |               Resolution:  needsinfo
     Keywords:                 |             Triage Stage:  Unreviewed
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+--------------------------------------
Changes (by Carlton Gibson):

 * status:  new => closed
 * resolution:   => needsinfo


Comment:

 Hi David. I'd be inclined to accept this — I think pre-commit is great —
 but I think we need to go via the DevelopersMailingList first to gather
 consensus.

 Ref [https://github.com/django/deps/blob/master/accepted/0008-black.rst
 DEP 8] this would be handy to have in place.

 Can I get you to post to the list? Some thoughts...

 * Things we could set up now: the whitespace rule, flake8, isort.
 * Add black when DEP 8 is implemented.
 * What's the setup? Add to docs where?
 * ...

 Thanks

-- 
Ticket URL: <https://code.djangoproject.com/ticket/32165#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4a572ed437e41bece16165a4d1460fb4%40djangoproject.com.

Reply via email to