#32215: documentation possible error - minor
-------------------------------------+-------------------------------------
     Reporter:  JD                   |                    Owner:  nobody
         Type:                       |                   Status:  closed
  Cleanup/optimization               |
    Component:  Documentation        |                  Version:  3.1
     Severity:  Normal               |               Resolution:  invalid
     Keywords:  possible             |             Triage Stage:
  documentation typo                 |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => invalid


Old description:

> On https://docs.djangoproject.com/en/3.1/topics/forms/modelforms/#topics-
> forms-modelforms
> Move comma in widget descriptor?
> it says:
> class AuthorForm(forms.Form):
>     name = forms.CharField(max_length=100)
>     title = forms.CharField(
>         max_length=3,
>         widget=forms.Select(choices=TITLE_CHOICES),
>     )
>     birth_date = forms.DateField(required=False)
> and I THINK should be:
> class AuthorForm(forms.Form):
>     name = forms.CharField(max_length=100)
>     title = forms.CharField(
>         max_length=3,
>         widget=forms.Select(choices=TITLE_CHOICES)
>     ),
>     birth_date = forms.DateField(required=False)

New description:

 On https://docs.djangoproject.com/en/3.1/topics/forms/modelforms/#topics-
 forms-modelforms
 Move comma in widget descriptor?
 it says:
 {{{
 class AuthorForm(forms.Form):
     name = forms.CharField(max_length=100)
     title = forms.CharField(
         max_length=3,
         widget=forms.Select(choices=TITLE_CHOICES),
     )
     birth_date = forms.DateField(required=False)
 }}}
 and I THINK should be:
 {{{
 class AuthorForm(forms.Form):
     name = forms.CharField(max_length=100)
     title = forms.CharField(
         max_length=3,
         widget=forms.Select(choices=TITLE_CHOICES)
     ),
     birth_date = forms.DateField(required=False)
 }}}

--

Comment:

 No, it's not a typo. `title` is a form field, with your patch it will be a
 tuple.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/32215#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1665d1ecbac2bfb07884e7af1237d90a%40djangoproject.com.

Reply via email to