#32385: contrib.admin's base template loads i18n twice
-------------------------------------+-------------------------------------
Reporter: Jim | Owner: Tim
Type: | McCurrach
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 3.1
Severity: Normal | Resolution:
Keywords: admin, template | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
Replying to [comment:4 Tim McCurrach]:
> I have created a PR for this. I had a look through the other templates
in contrib, to check for any similar instances of this. I didn't find any
duplicates but I did notice:
>
> - `...admin/prepopulated_fields_js.html` loads `l10n` but doesn't
appear to use any l10n template tags
> - `...admin/change_list_results.html` and
`...admin/edit_inline/stacked.html` loads `static` but doesn't appear to
use any static template tags
>
> Is it okay to remove those as well, and turn this into a general
template tags clear-up ticket. Or should they go into their own ticket?
Thanks for checking this, we can remove them in the same PR:
- `l10n` is unused in `prepopulated_fields_js.html` since
d638cdc42acec608c1967f44af6be32a477c239f,
- `static` is unused in `change_list_results.html` since
f2ed107b079b050950e2fc5f2b689ca553ae12f5,
- `static` is unused in `stacked.html` since
d61ebc8fed212366340b1ed6f5d7722613801459.
--
Ticket URL: <https://code.djangoproject.com/ticket/32385#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.5f8244c8c9ce46a4e48f1a40288d7cd6%40djangoproject.com.
