#32516: reorder_suite(reverse=True) isn't a strict reversal when duplicates are
present
-------------------------------------+-------------------------------------
Reporter: Chris | Owner: nobody
Jerdonek |
Type: | Status: assigned
Uncategorized |
Component: Testing | Version: 3.1
framework |
Severity: Normal | Keywords: reorder_suite
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
I noticed that when test duplicates are present, passing `reverse=True` to
[https://github.com/django/django/blob/286fb73b6962d197ed0cf041755fb724cfe08600/django/test/runner.py#L767
reorder_suite()] isn't always a strict reversal. For example, if the tests
given are `[test1, test2, test3, test1]`, then the forward direction will
be `[test1, test2, test3]`, but the reversed direction will be `[test1,
test3, test2]`.
This should be easy to fix by reversing only after duplicates are removed.
I would suggest fixing this only after
[https://github.com/django/django/pull/14085 PR #14085] is merged, since
there will be less code at that point.
--
Ticket URL: <https://code.djangoproject.com/ticket/32516>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/052.d23f86424e1a3889dbd0bd7f03eb8cab%40djangoproject.com.
