#32260: handler500 as a Class-based view raises SystemCheckError
-------------------------------------+-------------------------------------
Reporter: Daniyal Abbasi | Owner: Daniyal
Type: | Abbasi
Cleanup/optimization | Status: closed
Component: Core (System | Version: dev
checks) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"7c08f26bf0439c1ed593b51b51ad847f7e262bc1" 7c08f26b]:
{{{
#!CommitTicketReference repository=""
revision="7c08f26bf0439c1ed593b51b51ad847f7e262bc1"
Fixed #32260 -- Made View.as_view() do not use update_wrapper().
View.as_view() should not use update_wrapper() for copying attributes
it's unintended and have side-effects such as adding `self` to the
signature.
This also fixes system check for arguments of custom error handler
views with class-based views.
Co-authored-by: Nick Pope <[email protected]>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32260#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/071.16ea851a46ee1ecdcd3f9bb000419074%40djangoproject.com.
