#30416: Runserver's reloading mechanism should restore terminal state completely
-------------------------------------+-------------------------------------
     Reporter:  Daniel Hahler        |                    Owner:  Daniel
                                     |  Hahler
         Type:  Bug                  |                   Status:  assigned
    Component:  Core (Management     |                  Version:  2.2
  commands)                          |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  1                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

 * needs_tests:  0 => 1


Comment:

 I've left
 [https://github.com/django/django/pull/11291#pullrequestreview-625215987
 comments on PR] — ultimately I'm not sure we need to resolve this
 ourselves…

 Maybe offering a way to pause the auto-reloader if you're in a debugger
 (as per comment:5 — but not necessarily with the lock approach in linked
 PR), but even then, I'm not sure we're committed to the auto-reloader
 working flawlessly if you save file changes whilst working in the
 debugger.

 Possibly the suggested patch is a marginal improvement, but there are no
 tests at all. (Indeed some coverage is removed.) I'm not sure if we can
 come up with decent tests to make sure we don't introduce regressions.
 (It's on that untestable edge.) If we do merge this I think we need to ask
 regular contributors to try and break it with their debugging setup just
 to be sure we didn't break something else unexpectedly.

 Current status ≈-0

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30416#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.ed16d45a386af5c5bc841a460cf01244%40djangoproject.com.

Reply via email to