#32655: Improve error if a string is passed as an extra_test to
DiscoverRunner.build_suite()
-------------------------------------+-------------------------------------
     Reporter:  Chris Jerdonek       |                    Owner:  nobody
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:  Testing framework    |                  Version:  4.0
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
  iter_test_cases,DiscoverRunner,extra_tests|
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak):

 > Thanks. A couple thoughts: Before deprecating `extra_tests`, we might
 want to think through what the alternative escape hatch is for users that
 might want to add tests not currently available via discovery.

 They can always subclass `DiscoverRunner`. `extra_tests` is not used
 internally and it's untested. I don't think we need to provide any
 alternative. We can always ask for opinions on the DevelopersMailingList.

 > Though `iter_test_cases()` is an internal function, having the extra
 check could still help to avoid some puzzling moments.

 Agreed.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/32655#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.94dd422594bc04c6c65be3d967e84e1e%40djangoproject.com.

Reply via email to