#32675: Migration autodetector detects unnecessary changes.
----------------------------------+------------------------------------
     Reporter:  Mariusz Felisiak  |                    Owner:  nobody
         Type:  Bug               |                   Status:  new
    Component:  Migrations        |                  Version:  4.0
     Severity:  Release blocker   |               Resolution:
     Keywords:                    |             Triage Stage:  Accepted
    Has patch:  0                 |      Needs documentation:  0
  Needs tests:  0                 |  Patch needs improvement:  0
Easy pickings:  0                 |                    UI/UX:  0
----------------------------------+------------------------------------
Changes (by Simon Charette):

 * stage:  Unreviewed => Accepted


Comment:

 The idea of considering `to_field='id'` equivalent to a non-specified one
 is tempting but it could be wrong in theory even if it's rarely the case
 in practice.

 I personally don't think it's a big deal in practice since the detected
 `AlterField` is basically a noop if actually applied if I understand
 correctly?

 I'd be up for documenting that some noop operations might be generated due
 to this and we could alter the historical `admin` and `auth` ones to drop
 the `to_field` which is a remnant of Django 1.7 IIRC?

 If this is not deemed acceptable we could always resolve `to_field` as
 David described to prevent any behavior change.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/32675#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.43d696f57356ee2b010d4c68a512f92a%40djangoproject.com.

Reply via email to