#32717: Incorrect SQL generation filtering OR-combined queries
-------------------------------------+-------------------------------------
     Reporter:  Shaheed Haque        |                    Owner:  Simon
                                     |  Charette
         Type:  Bug                  |                   Status:  assigned
    Component:  Database layer       |                  Version:  3.2
  (models, ORM)                      |
     Severity:  Release blocker      |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Shaheed Haque):

 Replying to [comment:6 Simon Charette]:

 > Not totally necessary as the above patch that adjusts the
 ''optimization'' should address the issue, it'd be great if you could
 confirm it does, but it does make the behaviour of `Query.combine` more in
 line with the heavily tested paths the ORM usually takes.

 Yes, in testing here, I can confirm with the patch applied, that the
 broken case (post filter by 'GB') and the working case (post filter by
 'US') now generate similar SQL and - the right query results.

 And thank you for clarifying the use of "~Q()" for exclude...I'm not sure
 how I missed that.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/32717#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.da35e9d516e53c3d30e6e6fc636d9113%40djangoproject.com.

Reply via email to