#32808: DiscoverRunner.build_suite() does not restore
self.test_loader.testNamePatterns
---------------------------------------------+------------------------
Reporter: Chris Jerdonek | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version: 3.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------------+------------------------
`DiscoverRunner.build_suite()` does not restore
`self.test_loader.testNamePatterns` after setting it in this line:
https://github.com/django/django/blob/e703b152c6148ddda1b072a4353e9a41dca87f90/django/test/runner.py#L639
I noticed this issue when finding a test isolation issue while working on
#24522. The test
`test_runner.test_discover_runner.DiscoverRunnerTests.test_name_patterns`
passes `test_name_patterns` to `DiscoverRunner`:
https://github.com/django/django/blob/e703b152c6148ddda1b072a4353e9a41dca87f90/tests/test_runner/test_discover_runner.py#L119-L122
And this causes some later tests to fail.
--
Ticket URL: <https://code.djangoproject.com/ticket/32808>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/052.9ca10d55fc8369dd994f8cc25a97ba93%40djangoproject.com.
