#32508: Raise proper exceptions instead of using "assert".
--------------------------------------+------------------------------------
     Reporter:  Adam Johnson          |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  Core (Other)          |                  Version:  dev
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  0                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------

Comment (by Mariusz Felisiak):

 Replying to [comment:27 Mateo Radman]:
 > Hey guys, what is left to be done for this ticket?
 > Thanks.

 IMO, we have only two cases that could be updated (outside of
 `django.db.models`):
 - `django/db/backends/postgresql/creation.py` - `assert
 test_settings['COLLATION'] is None`
 - `django/test/testcases.py` - `assert not self.reset_sequences,
 'reset_sequences cannot be used on TestCase instances'`

 P.S. Note that we're not all "guys" so please use gender neutral
 greetings, https://heyguys.cc/

-- 
Ticket URL: <https://code.djangoproject.com/ticket/32508#comment:28>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.735e2955baeedabcfa2dc67e946cd470%40djangoproject.com.

Reply via email to