#32913: test_glob inside utils_tests.test_autoreload.WatchmanReloaderTests is
flaky
--------------------------------------+------------------------------------
Reporter: Abhyudai | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Nick Pope):
Strangely, with 0.6s running just the tests for
`utils_tests.test_autoreload.WatchmanReloaderTests` works consistently.
However, when running the entire test suite, I still get the following
failures:
{{{
ERROR: test_glob (utils_tests.test_autoreload.WatchmanReloaderTests)
ERROR: test_glob_recursive
(utils_tests.test_autoreload.WatchmanReloaderTests)
}}}
Bumping to 1 second, and even 1.5 seconds, seemed to result in the same
tests failing intermittently.
I seem to have had a reasonable amount of success with 2 seconds, so I've
updated the PR with that. (It's still better than 5 seconds which is the
default.)
Perhaps something else is at play that makes it worse when there are more
tests being executed, but I'm not sure what.
I'm wondering if we shouldn't allow the `DJANGO_WATCHMAN_TIMEOUT`
environment variable to be applicable when running the test suite also?
That'll allow users to easily overriding the value when running Django's
test suite. I added a fixup for that to the PR which can be squashed or
removed as required.
--
Ticket URL: <https://code.djangoproject.com/ticket/32913#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.1dcfbc7cbcc0a046fad8c8e8c3019db6%40djangoproject.com.
