#32951: Remove Query.where_class in favor of using WhereNode directly.
-------------------------------------+-------------------------------------
               Reporter:  Nick Pope  |          Owner:  Nick Pope
                   Type:             |         Status:  assigned
  Cleanup/optimization               |
              Component:  Database   |        Version:  dev
  layer (models, ORM)                |       Keywords:  wherenode,
               Severity:  Normal     |  where_class
           Triage Stage:             |      Has patch:  0
  Unreviewed                         |
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  0
                  UI/UX:  0          |
-------------------------------------+-------------------------------------
 #6261 added support for customized `WhereNode` and `QUERY_TERMS`.

 This was to "get GeoDjango working with the queryset-refactor branch" as
 it required a custom `GeoWhereNode` and being able to extend geographic
 lookup types.

 `QUERY_TERMS` was removed in 244cc401559e924355cf943b6b8e66ccf2f6da3a for
 Django 2.1 with the intended replacement being the Lookup Registration
 API.

 `GeoWhereNode` was removed in 3caf957ed5eaa831a485abcb89f27266dbf3e82b for
 Django 1.8, obsoleted by `GISLookup`.

 `Query.where_class` is internal and undocumented and is propagated around
 through other methods signatures, e.g. `.get_extra_restriction()`, which
 is also internal and undocumented. We should be able to remove this no
 longer necessary complexity and use `WhereNode` directly.

 Despite these being undocumented APIs, I don't know whether we want to go
 through a deprecation period?

-- 
Ticket URL: <https://code.djangoproject.com/ticket/32951>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.96a66694f9063c1274e49cef2940aadb%40djangoproject.com.

Reply via email to