#32959: URLValidator test cases can be defined in a Python module -------------------------------------+------------------------------------- Reporter: Chris Jerdonek | Owner: nobody Type: | Status: new Cleanup/optimization | Component: Testing framework | Version: dev Severity: Normal | Resolution: Keywords: | Triage Stage: | Unreviewed Has patch: 0 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 | UI/UX: 0 -------------------------------------+-------------------------------------
Comment (by Chris Jerdonek): That's a good thought and would indeed be better. But since the two files are only 76 lines and 87 lines, I think we could safely keep them next to / nearer the actual tests. In Django's code, it's not uncommon to find single functions that run to that length (and whole modules a great deal longer than that), so I don't see much problem in having test data of that length. (If we needed to split anything, splitting the `URLValidator` tests off from `DecimalValidator`, email tests, etc. into its own `test_urls.py` might be a more natural division.) -- Ticket URL: <https://code.djangoproject.com/ticket/32959#comment:3> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.3ff22e34b60ee174f96b6685dd5abaf3%40djangoproject.com.