#33007: `form_clean()` performance
--------------------------------------+------------------------------------
Reporter: David Smith | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Forms | Version: 3.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Chris Jerdonek):
> Thoughts?
If a PR's purpose is to optimize, but it adds complexity (like adding
caching), then it seems reasonable to me that there be an objective
measure that people can look to that shows improvement. A related example:
just in the last couple days, it was pointed out in
[https://github.com/django/django/pull/14748 this PR] that
`_lazy_re_compile()` (which was originally added as an optimization) was
actually slower in one instance. How many more are like that?
On the other hand, if a PR is doing something like removing a redundant
operation or eliminating an unneeded argument, I think it should be okay
even if a benchmark doesn't show a noticeable improvement. I know in some
cases like that, the commit message wound up saying something like
"Optimized ...," even if the impact might not really be noticeable. (I
think a message like "Simplified ..." or "Removed redundant ..." might be
more accurate in cases like that, so it doesn't overstate the impact.)
--
Ticket URL: <https://code.djangoproject.com/ticket/33007#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.c7721ff15ba0ac0c64543f82fb4ed8fb%40djangoproject.com.
