#32698: Move HttpRequest.get_raw_uri() to
ExceptionReporter._get_raw_insecure_uri().
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Hasan
Type: | Ramezani
Cleanup/optimization | Status: closed
Component: HTTP handling | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Jaap Roes):
Is it possible to reconsider the decision to flat out removal of
`get_raw_uri` instead of going through a deprecation period?
While testing Django 4.0a1 on one of our projects we noticed (by way of
failing tests) that one of our dependencies (authlib) currently relies on
the existence of `get_raw_uri`.
I created a [https://github.com/lepture/authlib/pull/385 PR] in that
project, so hopefully it'll be fixed before the release of Django 4.0.
Another tool we use (elastic-apm) guards the usage of `get_raw_uri` and
will [https://github.com/elastic/apm-agent-
python/blob/484ba5a1ad07e59bd4adeaf0291cc3da23d76afa/elasticapm/contrib/django/client.py#L155
fall back to pre-Django 1.9 behaviour] if that method doesn't exist.
Making it easy for the removal to go unnoticed. (I haven't made a PR there
as I'm unsure on what the correct fix would be, and I'm not willing to go
through the effort of signing their CLA)
--
Ticket URL: <https://code.djangoproject.com/ticket/32698#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.52644357997307693c547126b0a68962%40djangoproject.com.
