#33226: Add css class hooks to BaseForm
-------------------------------+--------------------------------------
Reporter: David Smith | Owner: nobody
Type: Uncategorized | Status: closed
Component: Uncategorized | Version: 3.2
Severity: Normal | Resolution: duplicate
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by Carlton Gibson):
* status: new => closed
* resolution: => duplicate
Comment:
Hey David, this is a duplicate of #14322.
''Possibly'' that's worth re-opening (via a discussion,
[https://docs.djangoproject.com/en/dev/internals/contributing/triaging-
tickets/#closing-tickets following triage guidelines for wontfix tickets])
— auto-complete and type checkers much prefer attributes to be defined (as
`None`?) rather than injected later.
I recall we've closed similar proposals along these lines though; often
the references are able to remain entirely within the injecting code,
whereas if they're declared (suddenly) they're split over multiple files.
(e.g. excluding usages, `required_css_class` appears **only** in
`boundfield.py`) — we didn't want to litter class definitions and/or init
methods with `None` declarations. (Better the tooling gets cleverer.)
Also #14322 (and #3512) were concerned about backwards compatibility. The
specific issue there may not apply after all this time, but it needs a
thought.
--
Ticket URL: <https://code.djangoproject.com/ticket/33226#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.496cf02209f58c547e7420758b7d6a24%40djangoproject.com.
