#33250: EmailField's label in PasswordResetForm doesn't match the verbose_name 
of
AbstractUser's EmailField
-------------------------------------+-------------------------------------
     Reporter:  Zoltán Szatmáry      |                    Owner:  nobody
         Type:                       |                   Status:  closed
  Cleanup/optimization               |
    Component:  contrib.auth         |                  Version:  3.2
     Severity:  Normal               |               Resolution:  wontfix
     Keywords:  EmailField           |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * type:  Bug => Cleanup/optimization
 * resolution:   => wontfix


Old description:

> django/contrib/auth/models.py:342
>
> email = models.EmailField(_('email address'), blank=True)
>
> django/contrib/auth/forms.py:242-246
>
> email = forms.EmailField(
>         label=_("Email"),
>         max_length=254,
>         widget=forms.EmailInput(attrs={'autocomplete': 'email'})
>     )

New description:

 {{{
 django/contrib/auth/models.py:342

 email = models.EmailField(_('email address'), blank=True)

 django/contrib/auth/forms.py:242-246

 email = forms.EmailField(
         label=_("Email"),
         max_length=254,
         widget=forms.EmailInput(attrs={'autocomplete': 'email'})
     )
 }}}

--

Comment:

 Thanks for this report, however IMO there is no need for them to be
 identical. The `Email` is completely valid and acceptable in the
 `PasswordResetForm`, it's not worth changing and creating extra work for
 translators.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/33250#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.d3ee251afc458a3ba990f71f2543b635%40djangoproject.com.

Reply via email to