#33365: Functionality change in 3.2.10 for re_path().
-------------------------------------+-------------------------------------
     Reporter:  Pkt                  |                    Owner:  nobody
         Type:  Bug                  |                   Status:  closed
    Component:  Core (URLs)          |                  Version:  3.2
     Severity:  Normal               |               Resolution:  invalid
     Keywords:  3.2.10 resolvers     |             Triage Stage:
  re_path                            |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Pkt):

 Hey, Mariusz &  Florian!

 Thanks for the quick answer.

 That's old code that we use so we can match any of these:

 /validate
 /auth/validate
 /v2/validate
 /v3/validate

 In this case all do the same, but some frontends will call different
 endpoints (other endpoints do have different results depending on URL),
 which is why we don't care to capture version (if present) in this case.
 Frontends will have a base url (with version included) and then call
 endpoints under that. It's not something I really like, but we do have a
 lot of legacy code to update, and that one is in the queue.

 Once we noticed the 404, we did indeed change it to
 {{{
 r"^.*validate$"
 }}}

 I like the idea of the warning, and I'd update the docs just so it doesn't
 happen to anyone else. I know it is a very rare case, but as it is now, it
 says "''a regular expression compatible with Python’s re module. [...]
 When a match is made''". It should mention that any regular expression
 ending in ''$'' will expect a full match.

 Oh, BTW, we validate email providers, but that's in the payload and sent
 as a POST, so it really makes no difference.

 Thanks!

-- 
Ticket URL: <https://code.djangoproject.com/ticket/33365#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.29b0a4b2d0e1a701d389f2892682d7eb%40djangoproject.com.

Reply via email to