#33471: AlterField operation should be noop when adding/changing choices on
SQLite.
-------------------------------------+-------------------------------------
Reporter: David Szotten | Owner: Douglas
Type: | Mumme
Cleanup/optimization | Status: assigned
Component: Migrations | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* cc: Adam Johnson (added)
* needs_better_patch: 0 => 1
Comment:
Replying to [comment:3 David Szotten]:
> could marking `choices` as a `non_database_attrs` adversely impact third
party fields that eg use a pg enum type to model `choices` values?
True, this would cause a regression for-party enum fields, e.g.
[https://github.com/adamchainz/django-mysql django-mysql's EnumField] a
similar field may exist for PostgreSQL or Oracle. It seems we can safely
overwrite `_field_should_be_altered()` only on SQLite.
--
Ticket URL: <https://code.djangoproject.com/ticket/33471#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/070.0aed96bb7272db27e5e877e3a9fcc67e%40djangoproject.com.
