#33501: order_with_respect_to uses incorrect database alias
-------------------------------------+-------------------------------------
     Reporter:  Damian Posener       |                    Owner:  Damian
                                     |  Posener
         Type:  Bug                  |                   Status:  assigned
    Component:  Database layer       |                  Version:  3.2
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  1                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Damian Posener):

 Replying to [comment:3 Simon Charette]:
 > You patch looks great Damian! It'd be even better if you write a test
 that ensures the updates are performed against the right database to
 prevent future regressions. I suggest you `grep` the test directory for
 `override_settings(DATABASE_ROUTERS` to get an idea of how you can route
 queries to the `other` test database and use
 `assertNumQueries(using='other')` to ensure it was properly routed.

 Thanks for the pointer, I've managed to sort out a regression test and
 have added it to my PR above. 👍

-- 
Ticket URL: <https://code.djangoproject.com/ticket/33501#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.08b587cece26c4c849c0f00e83170d9b%40djangoproject.com.

Reply via email to