#33589: Incomplete string escaping or encoding
-------------------------------------+-------------------------------------
               Reporter:  Shrikant   |          Owner:  nobody
  Dhayje                             |
                   Type:  Bug        |         Status:  new
              Component:             |        Version:  4.0
  contrib.admin                      |       Keywords:
               Severity:  Normal     |  bug,regex,Inaccurate
           Triage Stage:             |      Has patch:  1
  Unreviewed                         |
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  1
                  UI/UX:  0          |
-------------------------------------+-------------------------------------
 At
 The Given Code
 ```
 390| handleCalendarCallback: function(num) {
 391|            let format = get_format('DATE_INPUT_FORMATS')[0];
 392|            // the format needs to be escaped a little
 393|            format = format.replace('\\', '\\\\')
 394|                .replace('\r', '\\r')
 395|                .replace('\n', '\\n')
 396|                .replace('\t', '\\t')
 ```
 This replaces only the first occurrence of all the escape characters not
 all, and as per the the function is unable to completely accurate
 replacement of string with escape characters.

 This replaces only the first occurrence of "//", "/r", "/n", "/t" and "'",
 So We Should Use regex for replacing all occurrence.

 Used regex for easy updating.

 This issue "Has patch" https://github.com/django/django/pull/15460

-- 
Ticket URL: <https://code.djangoproject.com/ticket/33589>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107017fa88edc40-68116f43-90fa-4c1a-8faf-41f6fa983245-000000%40eu-central-1.amazonses.com.

Reply via email to