#33633: Some test_utils tests fail on databases that don't support transactions.
--------------------------------------+------------------------------------
Reporter: Xiang Zhang | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Xiang Zhang):
Replying to [comment:2 Mariusz Felisiak]:
> Thanks for the report. I was able to reproduce even more failures:
> {{{
> ERROR: test_failure_in_setUpTestData_should_rollback_transaction
(test_utils.tests.TestBadSetUpTestData)
> FAIL: test_reset_sequences (test_utils.test_testcase.TestTestCase)
> FAIL: test_class_attribute_identity
(test_utils.test_testcase.TestDataTests)
> FAIL: test_execute (test_utils.tests.CaptureOnCommitCallbacksTests)
> FAIL: test_execute_recursive
(test_utils.tests.CaptureOnCommitCallbacksTests)
> FAIL: test_execute_tree (test_utils.tests.CaptureOnCommitCallbacksTests)
> FAIL: test_no_arguments (test_utils.tests.CaptureOnCommitCallbacksTests)
> FAIL: test_pre_callback (test_utils.tests.CaptureOnCommitCallbacksTests)
> FAIL: test_using (test_utils.tests.CaptureOnCommitCallbacksTests)
> }}}
>
> `CaptureOnCommitCallbacksTests` should be skipped on databases that
don't support transactions, i.e. decorated with
`@skipUnlessDBFeature("supports_transactions")`. I didn't check other
failures. Would you like to prepare a patch?
Yes. I also find more tests fail but for me the three are most important.
Let me submit a fix.
--
Ticket URL: <https://code.djangoproject.com/ticket/33633#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/010701801c1537cb-d36a4944-07b0-4805-8038-107943b540b9-000000%40eu-central-1.amazonses.com.
