#33700: APPEND_SLASH adds significant latency to all requests not ending in /
(even
if successful)
-------------------------------------+-------------------------------------
Reporter: Anders Kaseorg | Owner: Anders
Type: | Kaseorg
Cleanup/optimization | Status: assigned
Component: HTTP handling | Version: 4.0
Severity: Normal | Resolution:
Keywords: CommonMiddleware | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* stage: Accepted => Ready for checkin
Comment:
This looks correct to me. #24720 (1.9) originally addressed the
performance issue of the check in `process_request`. This looks like it
regressed in #26293 (1.10) which handled the orthogonal logging issue. The
test changes in the PR here change to verify the whole middleware
behaviour, rather than just process_response. That looks OK.
I'll mark RFC, and leave for a period to allow others to check if they
wish, since CommonMiddleware is always sensitive.
--
Ticket URL: <https://code.djangoproject.com/ticket/33700#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/010701811968cd29-40c77d7c-bf97-421d-9c0b-cf0059ed392c-000000%40eu-central-1.amazonses.com.
