#33833: Close button styling issues in admin forms’ submit row
-------------------------------+--------------------------------------
Reporter: Thibaud Colas | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: button, focus | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Description changed by Thibaud Colas:
Old description:
> Picked up as part of reviewing #33728 /
> [https://github.com/django/django/pull/15734 PR #15734] – in the admin’s
> `submit_line.html` / `submit-row`, the Close button is misaligned:
>
> And it has an unexpected underline on focus:
>
>
> The misalignment & other spacing issues are particularly visible when
> there are multiple buttons displayed, though it’s not clear to me whether
> this actually happens in practice:
>
> ---
>
> To reproduce this, access a model form with a user who only has "View"
> permissions.
New description:
Picked up as part of reviewing #33728 /
[https://github.com/django/django/pull/15734 PR #15734] – in the admin’s
`submit_line.html` / `submit-row`, the Close button is misaligned:
[[Image(https://code.djangoproject.com/raw-attachment/ticket/33833/close-
button-admin.png)]]
And it has an unexpected underline on focus:
[[Image(https://code.djangoproject.com/raw-attachment/ticket/33833/close-
button-focus.png)]]
The misalignment & other spacing issues are particularly visible when
there are multiple buttons displayed, though it’s not clear to me whether
this actually happens in practice:
[[Image(https://code.djangoproject.com/raw-attachment/ticket/33833/close-
button-group.png)]]
This is also the case when buttons are displayed vertically in the
"mobile" viewports.
---
To reproduce this, access a model form with a user who only has "View"
permissions.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/33833#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070181db736ae7-2db5eff8-5f2d-4bef-abdb-4db65f9e2a53-000000%40eu-central-1.amazonses.com.
