#33868: Admin “delete object(s)” view: improve labels of m2m relations
-------------------------------------+-------------------------------------
Reporter: | Owner: nobody
[email protected] |
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: admin, delete view | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by [email protected]:
Old description:
> When deleting an object that has m2m relations in Django Admin, it shows
> a nice overview of what’s going to be deleted, including the records from
> m2m relations. An example screenshot is attached to the ticket.
>
> The labels for the m2m relations are constructed like this:
>
> //Photo-person relationship: Photo_depicts object (1)//
>
> //Photo-person relationship// makes perfect sense to me; //Photo_depicts
> object (1)// could be improved.
>
> I suggest using the labels of the string representation of the concrete
> from- and to-objects.
>
> Let me know what you think about it and I will see if I can come up with
> a patch.
>
> **Update:**
> Here’s a possible fix: https://github.com/django/django/pull/15884
> Some remarks:
> * It may be necessary to use a custom manager for the intermediary model
> to Ticket gets some attention
> * This is not a change to django admin (as planned), but it affects *all*
> auto-generated m2m models . What are the ceveats?
> * Translations are missing currently
> * I'm happy to provide tests if this goes in the right direction
>
> Background:
> Two years ago, I had a discussion on the Django developers mailing list
> about improving the labels that are used for m2m relations in Django
> Admin’s delete view. While reviewing old tickets to day, I checked the
> mailing list again and thought “Why not give it another shot?”.
> https://groups.google.com/g/django-developers/c/TxZtZyB3kpc
New description:
When deleting an object that has m2m relations in Django Admin, it shows a
nice overview of what’s going to be deleted, including the records from
m2m relations. An example screenshot is attached to the ticket.
The labels for the m2m relations are constructed like this:
//Photo-person relationship: Photo_depicts object (1)//
//Photo-person relationship// makes perfect sense to me; //Photo_depicts
object (1)// could be improved.
I suggest using the labels of the string representation of the concrete
from- and to-objects.
Let me know what you think about it and I will see if I can come up with a
patch.
**Update:**
Here’s a possible fix: https://github.com/django/django/pull/15884
Some remarks:
* The `from` and `to` models should be fetched with `select_related`
before `__str__` is called
* This is not a change to django admin (as planned), but it affects *all*
auto-generated m2m models . What are the ceveats?
* Translations are missing currently
* I'm happy to provide tests if this goes in the right direction
Background:
Two years ago, I had a discussion on the Django developers mailing list
about improving the labels that are used for m2m relations in Django
Admin’s delete view. While reviewing old tickets to day, I checked the
mailing list again and thought “Why not give it another shot?”.
https://groups.google.com/g/django-developers/c/TxZtZyB3kpc
--
--
Ticket URL: <https://code.djangoproject.com/ticket/33868#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/010701823c37d034-70335c4a-b13c-4528-92d6-f1b6f52e9993-000000%40eu-central-1.amazonses.com.
