#33898: Window() expression with ArrayAgg() crashes.
-------------------------------------+-------------------------------------
     Reporter:  Kia                  |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  4.1
  (models, ORM)                      |
     Severity:  Release blocker      |               Resolution:
     Keywords:  ArrayAgg, Window     |             Triage Stage:  Accepted
  function, extend, tuple, params    |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Simon Charette):

 This has become a true whack-a-mole game over the years.

 I think we should just bite the bullet and audit all of our `as_sql`
 functions to make sure they deal with params in `tuple` and not in `list`.
 Otherwise the only true way to cover all cases is to have a unit test for
 every combination of expression Django provides. Any thoughts on that
 Mariusz?

 Should we keep this issue focused on the `Window(ArrayAgg)` case or
 perform a larger audit meant to be backported? We could at least make sure
 all `as_sql` implementation are able to deal with `tuple | list` for now.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/33898#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e81770c-b3947672-c772-495d-b8b6-ff020d9dc1a0-000000%40eu-central-1.amazonses.com.

Reply via email to