#34023: ``inlines`` variable not bound in loop in ModelAdmin._create_formsets
--------------------------------------------+------------------------
               Reporter:  MichaƂ Pasternak  |          Owner:  nobody
                   Type:  Uncategorized     |         Status:  new
              Component:  Uncategorized     |        Version:  dev
               Severity:  Normal            |       Keywords:
           Triage Stage:  Unreviewed        |      Has patch:  0
    Needs documentation:  0                 |    Needs tests:  0
Patch needs improvement:  0                 |  Easy pickings:  0
                  UI/UX:  0                 |
--------------------------------------------+------------------------
 Hello,

 if you analyze this function with flake8 with bugbear extension:
 
https://github.com/django/django/blob/cd11664066087051ef11311708ebc55def48d1da/django/contrib/admin/options.py#L2254-L2278

 you will get an information about unbound variable ``inlines``, on this
 line:
 
https://github.com/django/django/blob/cd11664066087051ef11311708ebc55def48d1da/django/contrib/admin/options.py#L2265

 Not sure how big is the thread, but as inlines is likely a class and
 creating code to actually trigger this bug would be a bit complicated,
 perhaps it would be useful to just bound the variable in the function
 parameters and don't worry about eventual problems in the future?

-- 
Ticket URL: <https://code.djangoproject.com/ticket/34023>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070183545f4b8e-ea7ed035-d1ce-46dc-a589-42dc270018f5-000000%40eu-central-1.amazonses.com.

Reply via email to