#34030: add SystemCheckError for LocaleMiddleware
-------------------------------------+-------------------------------------
     Reporter:  Maxim Danilov        |                    Owner:  Jay Patel
         Type:  New feature          |                   Status:  closed
    Component:  Core (Management     |                  Version:  4.0
  commands)                          |
     Severity:  Normal               |               Resolution:  wontfix
     Keywords:  i18n, SystemCheck    |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 TBH I don't think this is worth the complexity.

 `LocaleMiddleware` is not required, and it's not in the default template,
 so someone has to both go and add it, and add it in the wrong place, which
 given they got through the i18n docs, I'm not sure is likely.

 Note also that whilst the `hint` for `admin.E410` says to ''insert between
 …'', we don't actually check that — just that `SessionMiddleware` is
 installed.

 I think trying to check exact/relative positions would be an unnecessary
 burden.

 I hope that makes sense.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/34030#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018383bed1f7-73f985f2-32f9-4246-bb9d-cfdd902c6ed3-000000%40eu-central-1.amazonses.com.

Reply via email to