#34093: Admin theme switcher icon should resize according to browser font size
-------------------------------------+-------------------------------------
     Reporter:  Thibaud Colas        |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  contrib.admin        |                  Version:  dev
     Severity:  Normal               |               Resolution:
     Keywords:  accessibility, ux,   |             Triage Stage:
  font size, dark mode               |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Description changed by Thibaud Colas:

Old description:

> The new admin theme switcher’s icon is a fixed 16x16px, regardless of the
> browser’s configured font size. It would be better for users requiring
> larger text if icons resized as well.
>
> This seems to be due to the icons’ SVG symbols having hard-coded `width`
> and `height` attributes, which prevents resizing with CSS. I believe the
> `width` and `height` should either be removed, or set on the inline SVG
> (which can be a bit tedious).
>
> Screenshot:
>
> Relevant code:
> https://github.com/django/django/blob/da8fa764134980ee1079f790cda6616f32cf9c44/django/contrib/admin/templates/admin/base.html#L118-L122

New description:

 The new admin theme switcher’s icon is a fixed 16x16px, regardless of the
 browser’s configured font size. It would be better for users requiring
 larger text if icons resized as well.

 This seems to be due to the icons’ SVG symbols having hard-coded `width`
 and `height` attributes, which prevents resizing with CSS. I believe the
 `width` and `height` should either be removed, or set on the inline SVG
 (which can be a bit tedious).

 Screenshot: https://code.djangoproject.com/raw-
 attachment/ticket/34093/Screenshot%202022-10-13%20at%2017.44.39.png

 Relevant code:
 
https://github.com/django/django/blob/da8fa764134980ee1079f790cda6616f32cf9c44/django/contrib/admin/templates/admin/base.html#L118-L122

--

-- 
Ticket URL: <https://code.djangoproject.com/ticket/34093#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070183d24ee9fb-9ec9557f-9462-4d5b-8047-998a38ac2314-000000%40eu-central-1.amazonses.com.

Reply via email to