#34172: Documentation of AdminSite.get_urls() encourages security 
vulnerabilities
--------------------------------------+------------------------------------
     Reporter:  Sylvain Fankhauser    |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  contrib.admin         |                  Version:  4.1
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  0                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by Carlton Gibson):

 * type:  Uncategorized => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 I tend to agree with the report here:

 > ... as some people might stop reading there ...

 I think that's likely very common. Folks just copy and paste without
 really reading.

 I take Mariusz' point that it's explained, but if a re-phrase is on offer,
 having one correct example with a ''couple of things to note... '' below,
 I think we should have a look at that.

 I'll Accept on that basis (assuming that's why Mariusz left it unreviewed)

 > Interested in submitting a documentation PR?

 Sylvain, if you wanted to assign it to yourself and open a PR, that would
 be great.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/34172#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701849e75c978-009dc896-dfd5-4028-a043-1e61aab141ed-000000%40eu-central-1.amazonses.com.

Reply via email to