#34283: Missing parameter escaping in admin filters.js
---------------------------------+-------------------------------------
Reporter: Stanislav | Owner: Stanislav
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+-------------------------------------
Comment (by Marcelo Galigniana):
Replying to [comment:5 Stanislav]:
> Replying to [comment:4 Mariusz Felisiak]:
> > Stanislav, Can you send PR via GitHub? (a regression test is
required.)
> I hope i did it
Hi Stanislav! I just saw your PR but it doesn’t have a new test. Marius
means add a test like this:
https://github.com/django/django/commit/27aa7035f57f0db30b6632e4274e18b430906799
#diff-640602cc17dc3e9a26db47f58b40a1289d5c0f1b5b0fe547810b1d962f6cde8b.
You could use it as a reference and add the escape case! Don’t forget
update the issue status here too!
Let me know if you need help with something!
--
Ticket URL: <https://code.djangoproject.com/ticket/34283#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070185eab53ada-78e381ab-ed0b-4db3-accb-b70382b9bde7-000000%40eu-central-1.amazonses.com.