#34303: Admin Site shall filter LogEntries by registered models
--------------------------------------+------------------------------------
     Reporter:  Jacob Rief            |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  contrib.admin         |                  Version:  4.2
     Severity:  Normal                |               Resolution:
     Keywords:  LogEntry              |             Triage Stage:  Accepted
    Has patch:  1                     |      Needs documentation:  1
  Needs tests:  0                     |  Patch needs improvement:  1
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1
 * stage:  Unreviewed => Accepted
 * needs_docs:  0 => 1


Comment:

 I'm always sceptical about new Admin API, but I'm going to Accept this, as
 I can see the use-case. (+0)

 I've left
 [https://github.com/django/django/pull/16508#pullrequestreview-1276649792
 comments on the first PR]. Summary: IMO, we should add only the minimal
 hook to let folks customise the `LogEntry` QuerySet, and document that,
 but not add the initially suggested helper methods and AdminSite flag
 attributes.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/34303#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018606e6d3e1-d85ecbf4-e402-4d91-9970-d1dc6a3dda4e-000000%40eu-central-1.amazonses.com.

Reply via email to