#34305: Refactor the GeoIP2 tests to use MaxMind test data
-------------------------------------+-------------------------------------
Reporter: Jacob | Owner: Tom Forbes
Walls |
Type: | Status: assigned
Cleanup/optimization |
Component: GIS | Version: dev
Severity: Normal | Keywords:
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Attempted to run the `gis_tests` today. Ran into the django-docker-box
[https://github.com/django/django-docker-box/issues/14 issue] that depends
on a refactor in Django itself, so opening a ticket here to track that
work.
Essentially, Tom Forbes proposes committing MaxMind test data to the
django repo to enable the `test_geoip2` to run without having to download
the city and country test files. Looking at the PR, a small refactor was
also necessary to enable using `@override_settings` to point to the files.
[https://github.com/django/django/pull/14215 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/34305>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070186099bc5b4-958f6f87-4764-4a5d-b1d2-0e0f7b4a0cbb-000000%40eu-central-1.amazonses.com.
