#34301: "show_save_as_new" in admin can add without this permission
-------------------------------------+-------------------------------------
     Reporter:  Equipe de TI da      |                    Owner:  Frédéric
  Zara Falcão                        |  Mheir
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.admin        |                  Version:  4.1
     Severity:  Normal               |               Resolution:
     Keywords:  save_as              |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  1                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak):

 Replying to [comment:11 Frédéric Mheir]:
 > Replying to [comment:10 Mariusz Felisiak]:
 > Hi Mariusz! Thanks a lot for your feedback. By making making a test that
 ensures "show_save_as_new" tag is False when "has_add_permission" is False
 (and other conditions True), would that be considered proper regression
 test? The logic is that only it would pass only with the patch.

 Yes, exactly.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/34301#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018627fef148-95d33d77-172c-4774-b2e1-788e3b67c9e6-000000%40eu-central-1.amazonses.com.

Reply via email to