#34322: ManifestStaticFilesStorage crashes on commented JavaScript import
statements
-------------------------------------+------------------------------------
Reporter: Adam Johnson | Owner: nobody
Type: Bug | Status: new
Component: contrib.staticfiles | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
Comment (by Claude Paroz):
This is in fact just one more occurrence of #21080, so the fact that
`ManifestStaticFileStorage` is broken with commented code, be it in CSS or
JS, is a known fact since some time. Every time we'll extend
`ManifestStaticFileStorage` functionality, we are going to worsen the
situation a bit more.
One possible mitigation could be to condition JS import support to a class
attribute, so it would at least allow people wanting to opt out of this
new functionality to subclass `ManifestStaticFileStorage` to fix any
possible issue with commented imports. I plead to keep this functionality
in 4.2 to allow those writing modern module-based JS in their projects to
safely use `ManifestStaticFileStorage`.
--
Ticket URL: <https://code.djangoproject.com/ticket/34322#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070186545eeabb-c37a4931-355a-404a-8223-97bc44017b3c-000000%40eu-central-1.amazonses.com.
