#34446: Coding style docs should contain incorrect example for Model style.
-------------------------------+------------------------------------
     Reporter:  JiriKr         |                    Owner:  nobody
         Type:  Bug            |                   Status:  new
    Component:  Documentation  |                  Version:  dev
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  1              |                    UI/UX:  0
-------------------------------+------------------------------------

Comment (by Mariusz Felisiak):

 TBH, I think this example is no longer needed as we have `black` CI
 builds. I'd remove it:

 {{{#!diff
 diff --git a/docs/internals/contributing/writing-code/coding-style.txt
 b/docs/internals/contributing/writing-code/coding-style.txt
 index 5b64e94b24..812be79c91 100644
 --- a/docs/internals/contributing/writing-code/coding-style.txt
 +++ b/docs/internals/contributing/writing-code/coding-style.txt
 @@ -279,15 +279,6 @@ Model style

    Don't do this::

 -      class Person(models.Model):
 -          first_name = models.CharField(max_length=20)
 -          last_name = models.CharField(max_length=40)
 -
 -          class Meta:
 -              verbose_name_plural = "people"
 -
 -  Don't do this, either::
 -
        class Person(models.Model):
            class Meta:
                verbose_name_plural = "people"

 }}}

-- 
Ticket URL: <https://code.djangoproject.com/ticket/34446#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070187318f2a0e-602c0a70-6153-4fb5-a51c-7559c1a98948-000000%40eu-central-1.amazonses.com.

Reply via email to