#34305: Refactor the GeoIP2 tests to use MaxMind test data
-------------------------------------+-------------------------------------
Reporter: Jacob Walls | Owner: Nick Pope
Type: | Status: closed
Cleanup/optimization |
Component: GIS | Version: dev
Severity: Normal | Resolution: fixed
Keywords: geoip, geoip2, | Triage Stage: Ready for
maxmind, maxmind-db, mmdb | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"a93375e8ab26e7cb22c6ee7e4bf23bf2d6ed170d" a93375e8]:
{{{
#!CommitTicketReference repository=""
revision="a93375e8ab26e7cb22c6ee7e4bf23bf2d6ed170d"
Fixed #34305 -- Changed GeoIP2 tests to use MaxMind test databases.
GEOIP_SETTINGS is removed from the global scope as this prevents
modifications to the settings using @override_settings in tests.
Additional improvements now that we have stable test databases include:
- Made testing more comprehensive and improved coverage
- Patched socket.gethostbyname() for whole test case
- Added testing of non-free GeoIP2 databases
Co-authored-by: Tom Forbes <t...@tomforb.es>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34305#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018c5dae0607-966ca11d-8bd5-41f7-9c8d-5cbd1fa2a793-000000%40eu-central-1.amazonses.com.
