#35065: Django Admin doesn't render autocomplete field whith error color border
properly.
-------------------------------------+-------------------------------------
     Reporter:  Rigoberto Villalta   |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  contrib.admin        |                  Version:  4.2
     Severity:  Normal               |               Resolution:
     Keywords:  Django 5.0, Django   |             Triage Stage:
  4.2, Django Admin                  |  Unreviewed
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Description changed by Rigoberto Villalta:

Old description:

> In Django Admin, if the validations of an autocomplete fields fails, the
> border of the input field isn't´n of the error color (#ba2121 by
> default).
>

> Why? Because in that case the  {{{select html element}}} is hidden.
>
> You can test it int this repo [https://github.com/Rigo-Villalta/django-
> autocomplete-error-not-visible].
>
> Solution: I think the best solution is to add to the end of the file
> ''/static/admin/css/autocomplete.css'' the following rule:
>

> {{{
> .errors .select2-selection {
>     border: 1px solid var(--error-fg);
> }
> }}}
>
> Someone could think that add the selector to the '' base.css'' file could
> works, but for inheritance doesn't work.
>
> I will push the pull request in a minutes, but I am not sure if is the
> best solution.

New description:

 In Django Admin, if the validations of an autocomplete fields fails, the
 border of the input field isn't´n of the error color (#ba2121 by default).

 [[Image(ticket:35065:django-admin-sample.PNG)]]

 Why? Because in that case the  {{{select html element}}} is hidden.

 You can test it int this repo [https://github.com/Rigo-Villalta/django-
 autocomplete-error-not-visible].

 Solution: I think the best solution is to add to the end of the file
 ''/static/admin/css/autocomplete.css'' the following rule:


 {{{
 .errors .select2-selection {
     border: 1px solid var(--error-fg);
 }
 }}}

 Someone could think that add the selector to the '' base.css'' file could
 works, but for inheritance doesn't work.

 I will push the pull request in a minutes, but I am not sure if is the
 best solution.

--

-- 
Ticket URL: <https://code.djangoproject.com/ticket/35065#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cad601fa8-c1954a5e-bd40-4505-85ff-0630630a5d47-000000%40eu-central-1.amazonses.com.

Reply via email to